fix: remove unsafe exec() in nsRemoteDebuggingPipe.cpp#40514
Closed
orbisai0security wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: remove unsafe exec() in nsRemoteDebuggingPipe.cpp#40514orbisai0security wants to merge 1 commit intomicrosoft:mainfrom
orbisai0security wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Automated security fix generated by Orbis Security AI
Member
|
Oh, this needs to be an issue, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
browser_patches/firefox/juggler/pipe/nsRemoteDebuggingPipe.cpp.Vulnerability
V-001browser_patches/firefox/juggler/pipe/nsRemoteDebuggingPipe.cpp:186Description: The memmove call at line 186 in nsRemoteDebuggingPipe.cpp computes its length as 'line.size() - start' without first verifying that 'start' is strictly less than 'line.size()'. If 'start' is derived from externally-supplied data in a malformed debugging protocol message and equals or exceeds 'line.size()', the subtraction underflows as an unsigned integer, producing an extremely large copy length. This causes an out-of-bounds write that corrupts heap memory, potentially enabling arbitrary code execution or a crash of the Firefox browser process used by Playwright.
Changes
browser_patches/firefox/juggler/pipe/nsRemoteDebuggingPipe.cppVerification
Automated security fix by OrbisAI Security